Re: [PATCH RFC 3/4] net: ethtool: Use uts_release
From: John Garry <john.g.garry@oracle.com>
Date: 2024-02-01 12:57:52
Also in:
linux-kbuild, linux-trace-kernel, lkml
Subsystem:
networking drivers, team driver, the rest · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Jiri Pirko, Linus Torvalds
On 31/01/2024 19:24, Jakub Kicinski wrote:
On Wed, 31 Jan 2024 10:48:50 +0000 John Garry wrote:quoted
Instead of using UTS_RELEASE, use uts_release, which means that we don't need to rebuild the code just for the git head commit changing. Signed-off-by: John Garry<john.g.garry@oracle.com>Yes, please! Acked-by: Jakub Kicinski<kuba@kernel.org>
Cheers
BTW, I assume that changes like this are also ok:
--------8<---------
net: team: Don't bother filling in ethtool driver version
The version is same as the default, as don't bother.
Signed-off-by: John Garry [off-list ref]
diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
index f575f225d417..0a44bbdcfb7b 100644
--- a/drivers/net/team/team.c
+++ b/drivers/net/team/team.c@@ -25,7 +25,6 @@#include <net/genetlink.h> #include <net/netlink.h> #include <net/sch_generic.h> -#include <generated/utsrelease.h> #include <linux/if_team.h> #define DRV_NAME "team"
@@ -2074,7 +2073,6 @@ static void team_ethtool_get_drvinfo(structnet_device *dev,
struct ethtool_drvinfo *drvinfo)
{
strscpy(drvinfo->driver, DRV_NAME, sizeof(drvinfo->driver));
- strscpy(drvinfo->version, UTS_RELEASE, sizeof(drvinfo->version));
}
-------->8---------
right?
John