Thread (17 messages) 17 messages, 5 authors, 2024-01-11

Re: [PATCH v4 net-next 1/5] net: phy: Add BaseT1 auto-negotiation constants

From: Andrew Lunn <andrew@lunn.ch>
Date: 2024-01-08 13:49:09
Also in: lkml

On Mon, Jan 08, 2024 at 10:36:56AM +0100, Dimitri Fedrau wrote:
Added constants for advertising 100BT1 and 1000BT1 in register BASE-T1
auto-negotiation advertisement register [31:16] (Register 7.515)

Signed-off-by: Dimitri Fedrau <redacted>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Sorry, more nit-picking :-(

Signed-off-by, Reviewed-by:, Fixes: etc should all be together. No
blanks lines between them. And Signed-off-by: comes last.

Given the missing statics, it looks like you will need to repost in
two weeks times.

       Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help