Re: [PATCH v2 1/3] net: phy: at803x: add QCA8084 ethernet phy support

On Mon, Nov 13, 2023 at 09:51:20PM +0200, Vladimir Oltean wrote:

On Mon, Nov 13, 2023 at 01:42:20PM +0000, Russell King (Oracle) wrote:

quoted

On Mon, Nov 13, 2023 at 01:58:52AM +0200, Vladimir Oltean wrote:

quoted

From 17fd68123d78f39a971f800de6da66522f71dc71 Mon Sep 17 00:00:00 2001
From: Vladimir Oltean <vladimir.oltean@nxp.com>
Date: Tue, 3 Oct 2023 22:16:25 +0300
Subject: [PATCH 1/2] net: phylink: move phylink_pcs_neg_mode() to phylink.c

Russell points out that there is no user of phylink_pcs_neg_mode()
outside of phylink.c, nor is there planned to be any, so we can just
move it there.

Looks familiar...

http://git.armlinux.org.uk/cgit/linux-arm.git/commit/?h=net-queue&id=c2aa9d3846c218d28a8a3457b0447998b0d84c5d

Well, yeah, I did mention that the patch was written at your suggestion,
and there aren't that many options in which that patch can be written.
I didn't look at your trees, and I made that change as part of a much
larger effort which involves phylink, which I will email you separately
about.

I will gladly drop my ownership on the first patch and ask Luo Jie to
pick your version instead, if this is what you're implying from the 2
word reply.

The reason that I hadn't submitted it was because I didn't want to move
the function out of the header file until the next LTS was released.

It seems 6.6 was announced as a LTS on the 17th November, so I'm happier
to now proceed with moving this into phylink.c.

as phylink_pcs_neg_mode() was merged in 6.5-rc1, it will have had three
kernel cycles - including one each side of the LTS release which I think
is reasonable.

I will send my patch hopefully sometime this week so it's in 6.8
depending on pressures.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!