Re: [PATCH v2 RFC 3/5] ethtool: adjust struct ethtool_keee to kernel needs

On Sat, Jan 06, 2024 at 11:20:43PM +0100, Heiner Kallweit wrote:

This patch changes the following in struct ethtool_keee
- remove member cmd, it's not needed on kernel side

Ah, O.K. That invalidates most of my comments on the previous
patch. Please expand the commit message of the previous patch to say
that keee cmd will be removed in the next patch.

- remove reserved fields
- switch the semantically boolean members to type bool

We don't have to change any user of the boolean members due to the
implicit casting from/to bool. A small change is needed where a
pointer to bool members is used, in addition remove few now unneeded
double negations.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew