Re: [PATCH] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY | netdev | Ratatoskr

[PATCH] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY · Dimitri Fedrau <hidden> · 2023-12-15
Re: [PATCH] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY · Andrew Lunn <andrew@lunn.ch> · 2023-12-16
Re: [PATCH] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY · Dimitri Fedrau <hidden> · 2023-12-16
Re: [PATCH] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY · Andrew Lunn <andrew@lunn.ch> · 2023-12-17
Re: [PATCH] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY · Dimitri Fedrau <hidden> · 2023-12-17
Re: [PATCH] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY · Stefan Eichenberger <hidden> · 2023-12-17
Re: [PATCH] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY · Dimitri Fedrau <hidden> · 2023-12-18
Re: [PATCH] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY · Stefan Eichenberger <hidden> · 2023-12-18
Re: [PATCH] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY · Dimitri Fedrau <hidden> · 2023-12-19
Re: [PATCH] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY · Stefan Eichenberger <hidden> · 2023-12-19
Re: [PATCH] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY · Dimitri Fedrau <hidden> · 2023-12-19
[PATCH v3 0/4] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY · Dimitri Fedrau <hidden> · 2023-12-21
[PATCH v3 1/4] net: phy: Add BaseT1 auto-negotiation constants · Dimitri Fedrau <hidden> · 2023-12-21
Re: [PATCH v3 1/4] net: phy: Add BaseT1 auto-negotiation constants · Andrew Lunn <andrew@lunn.ch> · 2023-12-21
[PATCH v3 2/4] net: phy: Support 100/1000BT1 linkmode advertisements · Dimitri Fedrau <hidden> · 2023-12-21
Re: [PATCH v3 2/4] net: phy: Support 100/1000BT1 linkmode advertisements · Andrew Lunn <andrew@lunn.ch> · 2023-12-21
[PATCH v3 3/4] net: phy: c45: detect 100/1000BASE-T1 linkmode advertisements · Dimitri Fedrau <hidden> · 2023-12-21
Re: [PATCH v3 3/4] net: phy: c45: detect 100/1000BASE-T1 linkmode advertisements · Andrew Lunn <andrew@lunn.ch> · 2023-12-21
[PATCH v3 4/4] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY · Dimitri Fedrau <hidden> · 2023-12-21
Re: [PATCH v3 4/4] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY · Andrew Lunn <andrew@lunn.ch> · 2023-12-21
Re: [PATCH v3 4/4] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY · Dimitri Fedrau <hidden> · 2023-12-21
Re: [PATCH v3 4/4] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY · Stefan Eichenberger <hidden> · 2023-12-21
Re: [PATCH v3 4/4] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY · Dimitri Fedrau <hidden> · 2023-12-21
Re: [PATCH v3 4/4] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY · Andrew Lunn <andrew@lunn.ch> · 2023-12-21
Re: [PATCH v3 4/4] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY · Dimitri Fedrau <hidden> · 2023-12-21
Re: [PATCH v3 4/4] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY · "Russell King (Oracle)" <linux@armlinux.org.uk> · 2024-01-02
Re: [PATCH v3 0/4] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY · Andrew Lunn <andrew@lunn.ch> · 2023-12-21
Re: [PATCH v3 0/4] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY · Dimitri Fedrau <hidden> · 2023-12-21
Re: [PATCH] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY · Andrew Lunn <andrew@lunn.ch> · 2023-12-19
Re: [PATCH] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY · Dimitri Fedrau <hidden> · 2024-01-05
Re: [PATCH] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY · Andrew Lunn <andrew@lunn.ch> · 2024-01-05
Re: [PATCH] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY · Dimitri Fedrau <hidden> · 2024-01-05
Re: [PATCH] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY · Andrew Lunn <andrew@lunn.ch> · 2024-01-05
Re: [PATCH] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY · Dimitri Fedrau <hidden> · 2024-01-05
[PATCH v2] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY · Dimitri Fedrau <hidden> · 2023-12-16

Re: [PATCH] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY

From: Andrew Lunn <andrew@lunn.ch>
Date: 2023-12-17 09:23:08
Also in: lkml

quoted

quoted

+	/* Set IEEE power down */
+	ret = phy_write_mmd(phydev, MDIO_MMD_PMAPMD, MDIO_CTRL1, 0x840);

0x800 is MDIO_CTRL1_LPOWER. What is the other? It seems like a speed
selection bit?

The other is MDIO_PMA_CTRL1_SPEED1000. Will fix this in V2.

It seems odd to set a speed, and power it down. But i guess you have
blindly copied the reference code, so have no idea why?

	Andrew