On 14/12/2023 15:50, Vladimir Oltean wrote:

On Thu, Dec 14, 2023 at 03:44:03PM +0200, Roger Quadros wrote:

quoted

On 14/12/2023 13:04, Vladimir Oltean wrote:

quoted

quoted

+	/* verify_timeout_count can only be set at valid link */
+	if (cfg->verify_time > 0)
+		port->qos.iet.verify_time_ms = cfg->verify_time;
+	else
+		port->qos.iet.verify_time_ms = 10;

I don't think I understand what the check is for? The netlink policy for
ETHTOOL_A_MM_VERIFY_TIME limits the range between 1 ms and 128 ms.
How can it be 0?

I didn't check ETHTOOL_A_MM_VERIFY_TIME before.

Not even when the exact same policy was rejecting the verify-time set by
LLDP in v6, for being larger than the upper limit of 128 ms? :-/

Sorry. I did check it before but overlooked it here. My memory seems to be failing me. :(

-- 
cheers,
-roger