RE: [EXT] Re: [PATCH net-next v3 2/4] octeon_ep: PF-VF mailbox version support
flat view
From: Shinas Rasheed <srasheed@marvell.com>
Date: 2023-12-11 15:39:44
Also in:
lkml
quoted
I'm afraid as to what else can be an alternative? The control net commandshave to be decoded and passed by the PF driver for the VFs,quoted
as only the PFs have access to talk to firmware directly. The VF drivers donot have an alternative way to query control net APIs, and may failquoted
if the control net APIs they have are not even recognized by the PF todecode them.quoted
Either VF commands which the PF can't support can be blocked at thesource (by the equivalent PF-VF backward compatibility which will exist in VF drivers)quoted
by this negotiation, or we have to let commands come through and failthem, leading to just redundancy in terms of running code. I don't see how this negotiation inquoted
any way 'limit' the VF drivers. As you said, in essence the VF drivers will have to fallback to v0 forbackward compatibility if the native host uses some old OS having older PF drivers. If not, thequoted
commands would come and fail anyways at the PF. Either way, it's an errorcase and this negotiation is just to decide if we are going to allow letting such commands in. I don't know what netdev maintainers will do with this code, I just pointed to this architecture/HW troublesome design. Thanks
I understand, thanks for your scrutiny. As I understand, its a case for letting errors run its course by letting unsupported commands in, or negotiate for a common version and stop earlier on control plane commands which the PF driver just doesn't know. Again, thanks for your constructive insight.