Re: [PATCH net-next v9 4/4] net: phy: add Rust Asix PHY driver
From: Andrew Lunn <andrew@lunn.ch>
Date: 2023-12-05 02:24:14
Also in:
rust-for-linux
From: Andrew Lunn <andrew@lunn.ch>
Date: 2023-12-05 02:24:14
Also in:
rust-for-linux
On Tue, Dec 05, 2023 at 03:54:48AM +0200, Jarkko Sakkinen wrote:
On Tue Dec 5, 2023 at 3:14 AM EET, FUJITA Tomonori wrote:quoted
This is the Rust implementation of drivers/net/phy/ax88796b.c. The features are equivalent. You can choose C or Rust version kernel configuration. Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com> Reviewed-by: Trevor Gross <tmgross@umich.edu> Reviewed-by: Benno Lossin <redacted>Hardware-agnostic feature must have something that spins in qemu, at least for a wide-coverage feature like phy it would be imho grazy to merge these without a phy driver that anyone can test out.
There are no hardware agnostic features here. PHY drivers are pretty
much thin layers which talk to the hardware. Take a look at the C
drivers, what hardware agnostic features do you see in them?
People can easily test this driver, its an easily available USB
dongle, which will work on any USB port, with any SoC architectures.
Andrew