On Tue, 05 Dec 2023 03:43:50 +0200
"Jarkko Sakkinen" [off-list ref] wrote:

On Tue Dec 5, 2023 at 3:14 AM EET, FUJITA Tomonori wrote:

quoted

This patch adds abstractions to implement network PHY drivers; the
driver registration and bindings for some of callback functions in
struct phy_driver and many genphy_ functions.

This feature is enabled with CONFIG_RUST_PHYLIB_ABSTRACTIONS=y.

Just a question: is `_ABSTRACTIONS` a convention or just for this
config flag?

It's a convention.

https://docs.kernel.org/rust/general-information.html#abstractions-vs-bindings

That would read anyway that this rust absraction of phy absraction
layer or similar.

Why not e.g.

- `CONFIG_RUST_PHYLIB_BINDINGS`
- `CONFIG_RUST_PHYLIB_API`
- Or even just `CONFIG_RUST_PHYLIB`?

I guess that CONFIG_RUST_PHYLIB_API or CONFIG_RUST_PHYLIB could be
used. CONFIG_RUST_PHYLIB_ABSTRACTIONS was preferred during the past
reviewing.