Thread (7 messages) 7 messages, 2 authors, 2023-12-01

Re: [patch net-next] docs: netlink: add NLMSG_DONE message format for doit actions

From: Jiri Pirko <jiri@resnulli.us>
Date: 2023-12-01 07:51:27

Thu, Nov 30, 2023 at 06:39:39PM CET, kuba@kernel.org wrote:
On Thu, 30 Nov 2023 14:30:36 +0100 Jiri Pirko wrote:
quoted
quoted
connector is a really bad example, the doc would have to say "some
families use NLMSG_DONE as an actual message type which may have pretty
much anything attached to it". It's not worth it, sorry.  
The existing documentation confuses uapi users (I have sample).
They expect error with NLMSG_DONE.
I hate this so much.
Unfortunatelly, Netlink has a lot of burden of misuse...

How about we say:

 Note that some families may issue custom NLMSG_DONE messages,
 in which case the payload is implementation-specific.
I'm fine with that. Will send v2.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help