Re: [patch net-next] docs: netlink: add NLMSG_DONE message format for doit actions
From: Jakub Kicinski <kuba@kernel.org>
Date: 2023-11-29 15:16:57
On Wed, 29 Nov 2023 15:46:15 +0100 Jiri Pirko wrote:
quoted
quoted
In case NLMSG_DONE message is sent as a reply to doit action, multiple kernel implementation do not send anything else than struct nlmsghdr. Add this note to the Netlink intro documentation.You mean when the reply has F_MULTI set, correct?Well, that would be ideal. However, that flag is parallel to NLMSG_DONE. I see that at least drivers/connector/connector.c does not set this flag when sending NLMSG_DONE type.
connector is a really bad example, the doc would have to say "some families use NLMSG_DONE as an actual message type which may have pretty much anything attached to it". It's not worth it, sorry. -- pw-bot: reject