Thread (66 messages) 66 messages, 4 authors, 2023-11-15

Re: [PATCH net-next v1 14/19] virtio_net: xsk: tx: virtnet_sq_free_unused_buf() check xsk buffer

From: Jason Wang <hidden>
Date: 2023-10-20 06:54:14
Also in: bpf, virtualization

On Mon, Oct 16, 2023 at 8:01 PM Xuan Zhuo [off-list ref] wrote:
virtnet_sq_free_unused_buf() check xsk buffer.

Signed-off-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Acked-by: Jason Wang <redacted>

Thanks

quoted hunk ↗ jump to hunk
---
 drivers/net/virtio/main.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/virtio/main.c b/drivers/net/virtio/main.c
index 1a222221352e..58bb38f9b453 100644
--- a/drivers/net/virtio/main.c
+++ b/drivers/net/virtio/main.c
@@ -3876,10 +3876,12 @@ static void free_receive_page_frags(struct virtnet_info *vi)

 void virtnet_sq_free_unused_buf(struct virtqueue *vq, void *buf)
 {
-       if (!virtnet_is_xdp_frame(buf))
+       if (virtnet_is_skb_ptr(buf))
                dev_kfree_skb(buf);
-       else
+       else if (virtnet_is_xdp_frame(buf))
                xdp_return_frame(virtnet_ptr_to_xdp(buf));
+
+       /* xsk buffer do not need handle. */
 }

 void virtnet_rq_free_unused_buf(struct virtqueue *vq, void *buf)
--
2.32.0.3.g01195cf9f
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help