Re: [PATCH net-next v1 13/19] virtio_net: xsk: tx: virtnet_free_old_xmit() distinguishes xsk buffer
From: Jakub Kicinski <kuba@kernel.org>
Date: 2023-10-16 23:44:36
Also in:
bpf
On Mon, 16 Oct 2023 20:00:27 +0800 Xuan Zhuo wrote:
quoted hunk ↗ jump to hunk
@@ -305,9 +311,15 @@ static inline void virtnet_free_old_xmit(struct virtnet_sq *sq, bool in_napi, stats->bytes += xdp_get_frame_len(frame); xdp_return_frame(frame); + } else { + stats->bytes += virtnet_ptr_to_xsk(ptr); + ++xsknum; } stats->packets++; } + + if (xsknum) + xsk_tx_completed(sq->xsk.pool, xsknum); }
sparse complains: drivers/net/virtio/virtio_net.h:322:41: warning: incorrect type in argument 1 (different address spaces) drivers/net/virtio/virtio_net.h:322:41: expected struct xsk_buff_pool *pool drivers/net/virtio/virtio_net.h:322:41: got struct xsk_buff_pool [noderef] __rcu *pool please build test with W=1 C=1 -- pw-bot: cr