On 30/10/2023 02:37, Rob Herring wrote:
On Sun, 29 Oct 2023 06:27:04 +0200, Cristian Ciocaltea wrote:
quoted
The Synopsys DesignWare MAC found on StarFive JH7100 SoC is quite
similar to the newer JH7110, but it requires only two interrupts and a
single reset line.
Signed-off-by: Cristian Ciocaltea <redacted>
---
.../devicetree/bindings/net/snps,dwmac.yaml | 1 +
.../bindings/net/starfive,jh7110-dwmac.yaml | 74 +++++++++++++------
2 files changed, 54 insertions(+), 21 deletions(-)
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.example.dtb: ethernet@c9410000: compatible: 'oneOf' conditional failed, one must be fixed:
'starfive,jh7100-dwmac' was expected
'amlogic,meson-gxbb-dwmac' is not one of ['starfive,jh7110-dwmac']
'snps,dwmac-5.20' was expected
from schema $id: http://devicetree.org/schemas/net/starfive,jh7110-dwmac.yaml#
And here you have proof of missing testing of patch #2.
Best regards,
Krzysztof