Re: [RFC PATCH net-next 02/12] devlink: Hold a reference on parent device

From
Jiri Pirko <jiri@resnulli.us>
Date
2023-10-17 09:01:44
Also in
linux-pci
Reply to
Ido Schimmel, 2023-10-17
Tue, Oct 17, 2023 at 10:11:24AM CEST, idosch@nvidia.com wrote:
On Tue, Oct 17, 2023 at 09:56:18AM +0200, Jiri Pirko wrote:
quoted
Tue, Oct 17, 2023 at 09:42:47AM CEST, idosch@nvidia.com wrote:
quoted
Each devlink instance is associated with a parent device and a pointer
to this device is stored in the devlink structure, but devlink does not
hold a reference on this device.

This is going to be a problem in the next patch where - among other
things - devlink will acquire the device lock during netns dismantle,
before the reload operation. Since netns dismantle is performed
asynchronously and since a reference is not held on the parent device,
it will be possible to hit a use-after-free.

Prepare for the upcoming change by holding a reference on the parent
device.
Just a note, I'm currently pushing the same patch as a part
of my patchset:
https://lore.kernel.org/all/20231013121029.353351-4-jiri@resnulli.us/ (local)
Then you probably need patch #1 as well:

https://lore.kernel.org/netdev/20231017074257.3389177-2-idosch@nvidia.com/ (local)
Correct.
Thread (24 messages) 24 messages, 5 authors, last reply 2023-10-25
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help