Re: [PATCH] KEYS: Include linux/errno.h in linux/verification.h

From
Daniel Borkmann <daniel@iogearbox.net>
Date
2023-08-28 09:34:02
Also in
ceph-devel, keyrings, linux-bluetooth, linux-crypto, linux-fscrypt, linux-nfs, linux-wireless, llvm, oe-kbuild-all
Reply to
Herbert Xu, 2023-08-26
Hi Herbert,

On 8/26/23 10:36 AM, Herbert Xu wrote:
quoted hunk ↗ jump to hunk
On Sat, Aug 26, 2023 at 02:58:48PM +0800, kernel test robot wrote:
quoted
All errors (new ones prefixed by >>):

    In file included from fs/ubifs/auth.c:12:
quoted
quoted
include/linux/verification.h:23:11: error: use of undeclared identifier 'EINVAL'
---8<---
Add inclusion of linux/errno.h as otherwise the reference to EINVAL
may be invalid.

Fixes: f3cf4134c5c6 ("bpf: Add bpf_lookup_*_key() and bpf_key_put() kfuncs")
Reported-by: kernel test robot <redacted>
Closes: https://lore.kernel.org/oe-kbuild-all/202308261414.HKw1Mrip-lkp@intel.com/ (local)
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
diff --git a/include/linux/verification.h b/include/linux/verification.h
index f34e50ebcf60..cb2d47f28091 100644
--- a/include/linux/verification.h
+++ b/include/linux/verification.h
@@ -8,6 +8,7 @@
  #ifndef _LINUX_VERIFICATION_H
  #define _LINUX_VERIFICATION_H
  
+#include <linux/errno.h>
  #include <linux/types.h>
  
  /*
Looks good, do you plan to route this fix to Linus?

Thanks,
Daniel
Thread (29 messages) 29 messages, 11 authors, last reply 2023-08-28
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help