Re: [PATCH 7/12] mptcp: Do not include crypto/algapi.h
From: Matthieu Baerts <hidden>
Date: 2023-08-23 12:54:57
Also in:
ceph-devel, linux-bluetooth, linux-crypto, linux-fscrypt, linux-integrity, linux-nfs, linux-wireless
Hello, On 23/08/2023 12:32, Herbert Xu wrote:
The header file crypto/algapi.h is for internal use only. Use the header file crypto/utils.h instead.
Thank you for the patch! It looks good to me: Acked-by: Matthieu Baerts <redacted> I understood that other patches will come later to make it clear crypto/algapi.h is for internal use only so that's good!
quoted hunk ↗ jump to hunk
diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c index 9ee3b7abbaf6..64bb200099dc 100644 --- a/net/mptcp/subflow.c +++ b/net/mptcp/subflow.c@@ -9,8 +9,8 @@ #include <linux/kernel.h> #include <linux/module.h> #include <linux/netdevice.h> -#include <crypto/algapi.h> #include <crypto/sha2.h> +#include <crypto/utils.h>
It is fine for me if you carry this patch in your tree: this part here has not changed for a while and there is no ongoing work going to modify it. So there should not be any conflicts when merging the different trees later. Cheers, Matt -- Tessares | Belgium | Hybrid Access Solutions www.tessares.net