Thread (38 messages) 38 messages, 5 authors, 2024-06-06

Re: [PATCH vhost v13 05/12] virtio_ring: introduce virtqueue_dma_dev()

From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2023-08-15 11:58:13
Also in: bpf, virtualization

On Tue, Aug 15, 2023 at 03:50:23PM +0800, Jason Wang wrote:
On Tue, Aug 15, 2023 at 2:32 PM Xuan Zhuo [off-list ref] wrote:
quoted

Hi, Jason

Could you skip this patch?
I'm fine with either merging or dropping this.
quoted
Let we review other patches firstly?
I will be on vacation soon, and won't have time to do this until next week.

But I spot two possible "issues":

1) the DMA metadata were stored in the headroom of the page, this
breaks frags coalescing, we need to benchmark it's impact
2) pre mapped DMA addresses were not reused in the case of XDP_TX/XDP_REDIRECT

I see Michael has merge this series so I'm fine to let it go first.

Thanks
it's still queued for next. not too late to drop or better add
a patch on top.

quoted
Thanks.
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help