Re: [RFC net-next v2 1/5] net: macsec: documentation for macsec_context and macsec_ops
From: Antoine Tenart <atenart@kernel.org>
Date: 2023-08-24 13:27:42
Also in:
lkml
From: Antoine Tenart <atenart@kernel.org>
Date: 2023-08-24 13:27:42
Also in:
lkml
Hello, Quoting Radu Pirea (NXP OSS) (2023-08-24 11:16:11)
/** * struct macsec_context - MACsec context for hardware offloading + * @netdev: pointer to the netdev if the SecY is offloaded to a MAC + * @phydev: pointer to the phydev if the SecY is offloaded to a PHY + * @offload: MACsec offload status
As this selects were the offload happens and how the two previous pointers can be accessed, might be nice to be a bit more explicit in the comments.
+ * @secy: pointer to a MACsec SecY + * @rx_sc: pointer to a RX SC + * @assoc_num: association number of the target SA + * @key: key of the target SA + * @rx_sa: pointer to an RX SA if a RX SA is added/updated/removed + * @tx_sa: pointer to an TX SA if a TX SA is added/updated/removed + * @tx_sc_stats: pointer to TX SC stats structure + * @tx_sa_stats: pointer to TX SA stats structure + * @rx_sc_stats: pointer to TX SC stats structure
s/TX/RX/ Thanks, Antoine