Re: [PATCH 3/5] dt-bindings: net: Add Loongson-1 DWMAC glue layer
From: Krzysztof Kozlowski <hidden>
Date: 2023-08-14 19:12:59
Also in:
linux-devicetree, linux-mips, lkml
On 12/08/2023 17:11, Keguang Zhang wrote:
quoted hunk ↗ jump to hunk
Add devicetree binding document for Loongson-1 DWMAC glue layer. Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com> --- .../bindings/net/loongson,ls1x-dwmac.yaml | 98 +++++++++++++++++++ .../devicetree/bindings/net/snps,dwmac.yaml | 2 + 2 files changed, 100 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/loongson,ls1x-dwmac.yamldiff --git a/Documentation/devicetree/bindings/net/loongson,ls1x-dwmac.yaml b/Documentation/devicetree/bindings/net/loongson,ls1x-dwmac.yaml new file mode 100644 index 000000000000..150799460599 --- /dev/null +++ b/Documentation/devicetree/bindings/net/loongson,ls1x-dwmac.yaml@@ -0,0 +1,98 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/loongson,ls1x-dwmac.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Loongson-1 DWMAC glue layer + +maintainers: + - Keguang Zhang <keguang.zhang@gmail.com> + +select: + properties: + compatible: + contains: + enum: + - loongson,ls1b-dwmac + - loongson,ls1c-dwmac + required: + - compatible + +properties: + compatible: + items: + - enum: + - loongson,ls1b-dwmac + - loongson,ls1c-dwmac + - const: snps,dwmac-3.50a + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + clock-names: + const: stmmaceth
This should be list (items) with one const item.
+ + interrupts: + maxItems: 1 + + interrupt-names: + const: macirq
Ditto
+ + syscon:
Let me quote: "Phandle to syscon device requires a vendor, descriptive name and a description" You only got description right.
+ $ref: /schemas/types.yaml#/definitions/phandle + description: + Phandle to the syscon containing some extra configurations + including PHY interface mode. + +required: + - compatible + - reg + - clocks + - clock-names + - interrupts + - interrupt-names + - phy-handle + - phy-mode
Drop, it is not defined here and already required by snps,dwmac.
quoted hunk ↗ jump to hunk
+ - syscon + +allOf: + - $ref: snps,dwmac.yaml# + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/clock/loongson,ls1x-clk.h> + #include <dt-bindings/interrupt-controller/irq.h> + + gmac0: ethernet@1fe10000 { + compatible = "loongson,ls1b-dwmac", "snps,dwmac-3.50a"; + reg = <0x1fe10000 0x10000>; + + clocks = <&clkc LS1X_CLKID_AHB>; + clock-names = "stmmaceth"; + + interrupt-parent = <&intc1>; + interrupts = <2 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "macirq"; + + phy-handle = <&phy0>; + phy-mode = "mii"; + + snps,pbl = <1>; + syscon = <&syscon>; + + mdio { + #address-cells = <1>; + #size-cells = <0>; + compatible = "snps,dwmac-mdio"; + + phy0: ethernet-phy@0 { + reg = <0x0>; + }; + }; + };diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml index ddf9522a5dc2..e1a956cf171e 100644 --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml@@ -66,6 +66,8 @@ properties: - ingenic,x2000-mac - loongson,ls2k-dwmac - loongson,ls7a-dwmac + - loongson,ls1b-dwmac + - loongson,ls1c-dwmac
You should not need it. Isn't snps,dwmac-3.50a already there? Anyway, not alphabetically ordered...
- qcom,qcs404-ethqos
- qcom,sa8775p-ethqos
- qcom,sc8280xp-ethqosBest regards, Krzysztof