-----Original Message-----
From: Jakub Kicinski <kuba@kernel.org>
Sent: Tuesday, August 1, 2023 2:58 PM
To: Shenwei Wang <shenwei.wang@nxp.com>

quoted

quoted

Subject: [EXT] Re: [PATCH v3 net 1/2] net: stmmac: add new mode
parameter for fix_mac_speed

Why is this quote included? Please get a sane email client.

I have no idea. We are using Office Outlook.

Regards,
Shenwei

quoted

quoted

On 31.07.2023 11:19:28, Shenwei Wang wrote:

quoted

A mode parameter has been added to the callback function of
fix_mac_speed to indicate the physical layer type.

The mode can be one the following:
  MLO_AN_PHY      - Conventional PHY
  MLO_AN_FIXED    - Fixed-link mode
  MLO_AN_INBAND   - In-band protocol

Also use short version of 'uint' to replace the 'unsigned int' in
the function definitions.

There are not many users of 'uint' in the kernel and it's not used
in the stmmac driver so far. From my point of view I would not
introduce it and stick to the standard 'unsigned int'.

Using 'uint' makes the code look cleaner because adding one extra
parameter may cause some function declarations to span multiple lines.
This change keeps function declarations compact on a single line.

Marc is right. Just do it.