-----Original Message-----
From: Marc Kleine-Budde <mkl@pengutronix.de>
Sent: Tuesday, August 1, 2023 1:37 AM
To: Shenwei Wang <shenwei.wang@nxp.com>
Cc: Russell King <linux@armlinux.org.uk>; David S. Miller
[off-list ref]; Eric Dumazet [off-list ref]; Jakub
Kicinski [off-list ref]; Paolo Abeni [off-list ref]; Maxime
Coquelin [off-list ref]; Shawn Guo [off-list ref];
Sascha Hauer [off-list ref]; Neil Armstrong
[off-list ref]; Kevin Hilman [off-list ref]; Vinod
Koul [off-list ref]; Chen-Yu Tsai [off-list ref]; Jernej Skrabec
[off-list ref]; Samuel Holland [off-list ref]; Jose
Abreu [off-list ref]; imx@lists.linux.dev; Simon Horman
[off-list ref]; Alexandre Torgue
[off-list ref]; Giuseppe Cavallaro
[off-list ref]; Nobuhiro Iwamatsu
[off-list ref]; Fabio Estevam [off-list ref];
linux-stm32@st-md-mailman.stormreply.com; Jerome Brunet
[off-list ref]; Bartosz Golaszewski
[off-list ref]; Wong Vee Khee [off-list ref]; dl-
linux-imx [off-list ref]; Andrew Halaney [off-list ref];
Bhupesh Sharma [off-list ref]; Martin Blumenstingl
[off-list ref]; Revanth Kumar Uppala
[off-list ref]; Jochen Henneberg [off-list ref];
linux-amlogic@lists.infradead.org; linux-arm-kernel@lists.infradead.org;
netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Pengutronix Kernel
Team [off-list ref]
Subject: [EXT] Re: [PATCH v3 net 1/2] net: stmmac: add new mode parameter
for fix_mac_speed

On 31.07.2023 11:19:28, Shenwei Wang wrote:

quoted

A mode parameter has been added to the callback function of
fix_mac_speed to indicate the physical layer type.

The mode can be one the following:
	MLO_AN_PHY	- Conventional PHY
	MLO_AN_FIXED	- Fixed-link mode
	MLO_AN_INBAND	- In-band protocol

Also use short version of 'uint' to replace the 'unsigned int' in the
function definitions.

There are not many users of 'uint' in the kernel and it's not used in the stmmac
driver so far. From my point of view I would not introduce it and stick to the
standard 'unsigned int'.

Using 'uint' makes the code look cleaner because adding one extra parameter may cause some function 
declarations to span multiple lines.  This change keeps function declarations compact on a single line.

Thanks,
Shenwei

Just my 2 cent,
Marc

--
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |