Re: [PATCH v2 23/28] net: wan: framer: Add support for the Lantiq PEF2256 framer

On Tue, 1 Aug 2023 12:52:29 +0200
Andrew Lunn [off-list ref] wrote:

quoted

quoted

quoted

+static void pef2256_isr_default_handler(struct pef2256 *pef2256, u8 nbr, u8 isr)
+{
+	dev_warn(pef2256->dev, "ISR%u: 0x%02x not handled\n", nbr, isr);
+}    

Should this be rate limited? It is going to be very noise if it gets
called once per frame time.  

This function should not be called.
It is wired on some interrupts and these interrupts should not be triggered.
It they fired, something was wrong.

I would prefer to keep this dev_warn() to keep the user informed about the
problem.  

I would definitely keep it, but rate limit it. dev_warn_ratelimited().

	Andrew

Ok, will be changed to dev_warn_ratelimited().

Hervé