Re: [PATCH v2 23/28] net: wan: framer: Add support for the Lantiq PEF2256 framer

From
Andrew Lunn <andrew@lunn.ch>
Date
2023-08-01 10:27:15
Also in
alsa-devel, linux-arm-kernel, linux-devicetree, linux-gpio, linuxppc-dev, lkml
Reply to
Herve Codina, 2023-07-26
quoted hunk ↗ jump to hunk
+static inline u8 pef2256_read8(struct pef2256 *pef2256, int offset)
+{
+	int val;
+
+	regmap_read(pef2256->regmap, offset, &val);
+	return val;
+}
+
+static inline void pef2256_write8(struct pef2256 *pef2256, int offset, u8 val)
+{
+	regmap_write(pef2256->regmap, offset, val);
+}
More cases of inline functions in .C files. Please let the compiler
decide.
quoted hunk ↗ jump to hunk
+static void pef2256_isr_default_handler(struct pef2256 *pef2256, u8 nbr, u8 isr)
+{
+	dev_warn(pef2256->dev, "ISR%u: 0x%02x not handled\n", nbr, isr);
+}
Should this be rate limited? It is going to be very noise if it gets
called once per frame time.

       Andrew
Thread (91 messages) 91 messages, 8 authors, last reply 2023-08-08
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help