Thread (91 messages) 91 messages, 8 authors, 2023-08-08

Re: [PATCH v2 20/28] net: wan: Add framer framework support

From: Herve Codina <herve.codina@bootlin.com>
Date: 2023-08-01 10:32:13
Also in: alsa-devel, linux-arm-kernel, linux-devicetree, linux-gpio, linuxppc-dev, lkml

On Tue, 1 Aug 2023 11:56:12 +0200
Andrew Lunn [off-list ref] wrote:
quoted
+int framer_pm_runtime_get(struct framer *framer)
+{
+	int ret;
+
+	if (!framer)
+		return 0;  
Can framer be a NULL pointer? This sort of test often covers up
bugs. So either let it dereference the NULL pointer and opps, or
return -EINVAL.
Well, in the current usage, it cannot be a NULL pointer.
I will simply remove the check (every where it is present) and
dereference the pointer instead of returning -EINVAL.

Regards,
Hervé

-- 
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help