Re: [PATCH v2 20/28] net: wan: Add framer framework support

From
Andrew Lunn <andrew@lunn.ch>
Date
2023-08-01 09:57:16
Also in
alsa-devel, linux-arm-kernel, linux-devicetree, linux-gpio, linuxppc-dev, lkml
Reply to
Herve Codina, 2023-07-26
quoted hunk ↗ jump to hunk
+int framer_pm_runtime_get(struct framer *framer)
+{
+	int ret;
+
+	if (!framer)
+		return 0;
Can framer be a NULL pointer? This sort of test often covers up
bugs. So either let it dereference the NULL pointer and opps, or
return -EINVAL.

       Andrew
Thread (91 messages) 91 messages, 8 authors, last reply 2023-08-08
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help