Thread (13 messages) 13 messages, 4 authors, 2023-07-04

Re: [PATCH 1/3] dt-bindings: i3c: Add mctp-controller property

From: Matt Johnston <matt@codeconstruct.com.au>
Date: 2023-07-03 08:04:25
Also in: linux-devicetree, linux-i3c

On Mon, 2023-07-03 at 09:15 +0200, Krzysztof Kozlowski wrote:
On Mon, 3 Jul 2023 at 07:31, Matt Johnston [off-list ref] wrote:
quoted
This property is used to describe a I3C bus with attached MCTP I3C
target devices.

Signed-off-by: Matt Johnston <matt@codeconstruct.com.au>
---
 Documentation/devicetree/bindings/i3c/i3c.yaml | 4 ++++
 1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/i3c/i3c.yaml b/Documentation/devicetree/bindings/i3c/i3c.yaml
index fdb4212149e7..08731e2484f2 100644
--- a/Documentation/devicetree/bindings/i3c/i3c.yaml
+++ b/Documentation/devicetree/bindings/i3c/i3c.yaml
@@ -55,6 +55,10 @@ properties:

       May not be supported by all controllers.

+  mctp-controller:
+    description: |
+      Indicates that this bus hosts MCTP-over-I3C target devices.
I have doubts you actually tested it - there is no type/ref. Also,
your description is a bit different than existing from dtschema. Why?
Aren't these the same things?
Ah, I'll add 
$ref: /schemas/types.yaml#/definitions/flag

I ran dt_binding_check andmake dt_binding_check \    
  DT_SCHEMA_FILES=Documentation/devicetree/bindings/i3c/i3c.yaml

?



Best regards,
Krzysztof
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help