[PATCH v12 12/26] nvme-tcp: Only enable offload with TLS if the driver supports it
STALE1141d
REVIEWED: 1 (1M)
From: Aurelien Aptel <hidden>
Date: 2023-07-12 16:17:58
Also in:
linux-nvme
Subsystem:
nvm express driver, the rest · Maintainers:
Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg, Linus Torvalds
Revision v12 of 25 in this series; 1 review trailer.
Revisions (25)
- v6 [diff vs current]
- v7 [diff vs current]
- v8 [diff vs current]
- v9 [diff vs current]
- v10 [diff vs current]
- v11 [diff vs current]
- v12 current
- v13 [diff vs current]
- v14 [diff vs current]
- v15 [diff vs current]
- v16 [diff vs current]
- v17 [diff vs current]
- v18 [diff vs current]
- v19 [diff vs current]
- v20 [diff vs current]
- v21 [diff vs current]
- v22 [diff vs current]
- v23 [diff vs current]
- v24 [diff vs current]
- v25 [diff vs current]
- v26 [diff vs current]
- v27 [diff vs current]
- v28 [diff vs current]
- v29 [diff vs current]
- v30 [diff vs current]
Check if ULP offload driver supports ULP-over-TLS before enabling the offload with tls. Signed-off-by: Aurelien Aptel <redacted> Signed-off-by: Shai Malin <redacted> Reviewed-by: Max Gurtovoy <mgurtovoy@nvidia.com> --- drivers/nvme/host/tcp.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c
index e560bdf3a023..afb3dedcbc0c 100644
--- a/drivers/nvme/host/tcp.c
+++ b/drivers/nvme/host/tcp.c@@ -367,6 +367,10 @@ static inline bool is_netdev_ulp_offload_active(struct net_device *netdev, if (!nvme_tcp_ddp_query_limits(netdev, queue)) return false; + /* If we are using TLS and netdev doesn't support it, do not offload */ + if (queue->ctrl->ctrl.opts->tls && !queue->ddp_limits.tls) + return false; + /* If netdev supports nvme-tcp ddp offload, we can offload */ if (test_bit(ULP_DDP_C_NVME_TCP_BIT, netdev->ulp_ddp_caps.active)) return true;
--
2.34.1