[PATCH v12 12/26] nvme-tcp: Only enable offload with TLS if the driver supports it
From: Aurelien Aptel <hidden>
Date: 2023-07-12 16:17:58
Also in:
linux-nvme
Subsystem:
nvm express driver, the rest · Maintainers:
Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg, Linus Torvalds
Check if ULP offload driver supports ULP-over-TLS before enabling the offload with tls. Signed-off-by: Aurelien Aptel <redacted> Signed-off-by: Shai Malin <redacted> Reviewed-by: Max Gurtovoy <mgurtovoy@nvidia.com> --- drivers/nvme/host/tcp.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c
index e560bdf3a023..afb3dedcbc0c 100644
--- a/drivers/nvme/host/tcp.c
+++ b/drivers/nvme/host/tcp.c@@ -367,6 +367,10 @@ static inline bool is_netdev_ulp_offload_active(struct net_device *netdev, if (!nvme_tcp_ddp_query_limits(netdev, queue)) return false; + /* If we are using TLS and netdev doesn't support it, do not offload */ + if (queue->ctrl->ctrl.opts->tls && !queue->ddp_limits.tls) + return false; + /* If netdev supports nvme-tcp ddp offload, we can offload */ if (test_bit(ULP_DDP_C_NVME_TCP_BIT, netdev->ulp_ddp_caps.active)) return true;
--
2.34.1