Re: [PATCH v2 17/47] rcu: dynamically allocate the rcu-lazy shrinker
From: Muchun Song <muchun.song@linux.dev>
Date: 2023-07-26 07:08:32
Also in:
dm-devel, dri-devel, kvm, linux-arm-msm, linux-bcache, linux-btrfs, linux-ext4, linux-f2fs-devel, linux-fsdevel, linux-mm, linux-nfs, linux-raid, linux-xfs, lkml, rcu, xen-devel
quoted hunk ↗ jump to hunk
On Jul 24, 2023, at 17:43, Qi Zheng [off-list ref] wrote: Use new APIs to dynamically allocate the rcu-lazy shrinker. Signed-off-by: Qi Zheng <redacted> --- kernel/rcu/tree_nocb.h | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-)diff --git a/kernel/rcu/tree_nocb.h b/kernel/rcu/tree_nocb.h index 43229d2b0c44..919f17561733 100644 --- a/kernel/rcu/tree_nocb.h +++ b/kernel/rcu/tree_nocb.h@@ -1397,12 +1397,7 @@ lazy_rcu_shrink_scan(struct shrinker *shrink, struct shrink_control *sc)return count ? count : SHRINK_STOP; } -static struct shrinker lazy_rcu_shrinker = { - .count_objects = lazy_rcu_shrink_count, - .scan_objects = lazy_rcu_shrink_scan, - .batch = 0, - .seeks = DEFAULT_SEEKS, -}; +static struct shrinker *lazy_rcu_shrinker;
Seems there is no users of this variable, maybe we could drop this.