Thread (17 messages) 17 messages, 4 authors, 2023-07-27

Re: [PATCH v3 8/8] lib: test for_each_numa_cpus()

From: Yury Norov <yury.norov@gmail.com>
Date: 2023-07-27 02:11:10
Also in: linux-rdma, lkml

On Sat, Jul 22, 2023 at 08:47:16AM -0700, Guenter Roeck wrote:
Hi,

On Sun, Apr 30, 2023 at 10:18:09AM -0700, Yury Norov wrote:
quoted
Test for_each_numa_cpus() output to ensure that:
 - all CPUs are picked from NUMA nodes with non-decreasing distances to the
   original node; 
 - only online CPUs are enumerated;
 - the macro enumerates each online CPUs only once;
 - enumeration order is consistent with cpumask_local_spread().

The latter is an implementation-defined behavior. If cpumask_local_spread()
or for_each_numa_cpu() will get changed in future, the subtest may need
to be adjusted or even removed, as appropriate.

It's useful now because some architectures don't implement numa_distance(),
and generic implementation only distinguishes local and remote nodes, which
doesn't allow to test the for_each_numa_cpu() properly.
This patch results in a crash when testing sparc64 images with qemu.
Thanks Guenter for reporting. I'll remove the series until fixing the
issue.

Thanks,
Yury
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help