-----Original Message-----
From: Krzysztof Kozlowski <krzk@kernel.org>
Sent: Saturday, July 22, 2023 12:22 AM
To: Ng, Boon Khai <redacted>; Boon@ecsmtp.png.intel.com;
Khai@ecsmtp.png.intel.com; Giuseppe Cavallaro [off-list ref];
Alexandre Torgue [off-list ref]; Jose Abreu
[off-list ref]; David S . Miller [off-list ref]; Eric
Dumazet [off-list ref]; Jakub Kicinski [off-list ref];
Paolo Abeni [off-list ref]; Maxime Coquelin
[off-list ref]; netdev@vger.kernel.org; linux-stm32@st-
md-mailman.stormreply.com; linux-arm-kernel@lists.infradead.org; linux-
kernel@vger.kernel.org
Cc: Shevchenko, Andriy <redacted>; Tham, Mun Yew
[off-list ref]; Swee, Leong Ching
[off-list ref]; G Thomas, Rohan
[off-list ref]; Shevchenko Andriy
[off-list ref]
Subject: Re: [Enable Designware XGMAC VLAN Stripping Feature 1/2] dt-
bindings: net: snps,dwmac: Add description for rx-vlan-offload

On 21/07/2023 17:28, Ng, Boon Khai wrote:

quoted

quoted

-----Original Message-----
From: Krzysztof Kozlowski <krzk@kernel.org>
Sent: Friday, July 21, 2023 6:11 PM
To: Boon@ecsmtp.png.intel.com; Khai@ecsmtp.png.intel.com; "Ng
<boon.khai.ng"@intel.com; Giuseppe Cavallaro
[off-list ref]; Alexandre Torgue
[off-list ref]; Jose Abreu [off-list ref];
David S . Miller [off-list ref]; Eric Dumazet
[off-list ref]; Jakub Kicinski [off-list ref]; Paolo

Abeni

quoted

quoted

[off-list ref]; Maxime Coquelin

[off-list ref];

quoted

quoted

netdev@vger.kernel.org; linux-stm32@st-md- mailman.stormreply.com;
linux-arm-kernel@lists.infradead.org; linux- kernel@vger.kernel.org
Cc: Ng, Boon Khai <redacted>; Shevchenko, Andriy
[off-list ref]; Tham, Mun Yew
[off-list ref]; Swee, Leong Ching
[off-list ref]; G Thomas, Rohan
[off-list ref]; Shevchenko Andriy
[off-list ref]
Subject: Re: [Enable Designware XGMAC VLAN Stripping Feature 1/2] dt-

bindings:

quoted

quoted

net: snps,dwmac: Add description for rx-vlan-offload

On 21/07/2023 08:26, Boon@ecsmtp.png.intel.com wrote:

quoted

From: Boon Khai Ng <redacted>

This patch is to add the dts setting for the MAC controller on
synopsys 10G Ethernet MAC which allow the 10G MAC to turn on
hardware accelerated VLAN stripping. Once the hardware accelerated
VLAN stripping is turn on, the VLAN tag will be stripped by the

Subject prefix is totally bogus.

Which part? It's a 10G Ethernet IP from Sysnopsys, in Roman character it is

X (mean 10), so XGMAC.

quoted

Even the driver file I'm editing it is dw"xgmac".

Everything in [].

quoted

quoted

quoted

10G Ethernet MAC.

Signed-off-by: Boon Khai Ng <redacted>
Reviewed-by: Shevchenko Andriy <andriy.shevchenko@linux.intel.com>

Please use scripts/get_maintainers.pl to get a list of necessary
people and lists to CC. It might happen, that command when run on an
older kernel, gives you outdated entries. Therefore please be sure
you base your patches on recent Linux kernel.

This is based on net-next repository suggested by the get maintainer script.

I got the latest net-next just now at the Commit-id b44693495af8 which
just committed yesterday.

$ ./scripts/get_maintainer.pl  --scm  -f
drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c

That's not how you run it. get_maintainers.pl should be run on patches or on
all files, not just some selection.

quoted

Giuseppe Cavallaro [off-list ref] (supporter:STMMAC

ETHERNET

quoted

DRIVER) Alexandre Torgue [off-list ref]
(supporter:STMMAC ETHERNET DRIVER) Jose Abreu

[off-list ref]

quoted

(supporter:STMMAC ETHERNET DRIVER) "David S. Miller"
[off-list ref] (maintainer:NETWORKING DRIVERS) Eric

Dumazet

quoted

[off-list ref] (maintainer:NETWORKING DRIVERS) Jakub

Kicinski

quoted

[off-list ref] (maintainer:NETWORKING DRIVERS) Paolo Abeni
[off-list ref] (maintainer:NETWORKING DRIVERS) Maxime

Coquelin

quoted

[off-list ref] (maintainer:ARM/STM32 ARCHITECTURE)
Richard Cochran [off-list ref] (maintainer:PTP HARDWARE
CLOCK SUPPORT) netdev@vger.kernel.org (open list:STMMAC ETHERNET
DRIVER) linux-stm32@st-md-mailman.stormreply.com (moderated
list:ARM/STM32 ARCHITECTURE) linux-arm-kernel@lists.infradead.org
(moderated list:ARM/STM32 ARCHITECTURE) linux-kernel@vger.kernel.org
(open list) git
git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git
git git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git
git git://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git
stm32-next git
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

quoted

You missed at least DT list (maybe more), so this won't be tested by
automated tooling. Performing review on untested code might be a
waste of time, thus I will skip this patch entirely till you follow
the process allowing the patch to be tested.

This is a new device bringup, thus the DT is not available yet. The
DTS will be upstreamed by my another colleague, unless, if I can upstream

only my part on the setting?

You are mixing now DTS and DT bindings. Sorry, we do not talk about DTS.

Follow our process of submitting patches. For sure there are folks in Intel
which can explain it to you.

Ah see, so you were saying I'm missing the cc list of the maintainer related to the
DT binding. 

Best regards,
Krzysztof