On Thu, Jul 20, 2023 at 9:59 AM Abel Wu [off-list ref] wrote:

Gentle ping :)

I was hoping for some feedback from memcg experts.

You claim to fix a bug, please provide a Fixes: tag so that we can
involve original patch author.

Thanks.

On 7/11/23 8:41 PM, Abel Wu wrote:

quoted

Now there are two indicators of socket memory pressure sit inside
struct mem_cgroup, socket_pressure and tcpmem_pressure.

When in legacy mode aka. cgroupv1, the socket memory is charged
into a separate counter memcg->tcpmem rather than ->memory, so
the reclaim pressure of the memcg has nothing to do with socket's
pressure at all. While for default mode, the ->tcpmem is simply
not used.

So {socket,tcpmem}_pressure are only used in default/legacy mode
respectively. This patch fixes the pieces of code that make mixed
use of both.

Signed-off-by: Abel Wu <redacted>
---
  include/linux/memcontrol.h | 4 ++--
  mm/vmpressure.c            | 8 ++++++++
  2 files changed, 10 insertions(+), 2 deletions(-)