Re: [PATCH net-next v2 4/7] net: dsa: vsc73xx: Add dsa tagging based on 8021q
From: Vladimir Oltean <olteanv@gmail.com>
Date: 2023-07-03 16:16:33
Also in:
lkml
On Sun, Jun 25, 2023 at 01:53:39PM +0200, Pawel Dembicki wrote:
quoted hunk ↗ jump to hunk
This patch is simple implementation of 8021q tagging in vsc73xx driver. At this moment devices with DSA_TAG_PROTO_NONE are useless. VSC73XX family doesn't provide any tag support for external ethernet ports. The only way is vlan-based tagging. It require constant hardware vlan filtering. VSC73XX family support provider bridging but QinQ only without fully implemented 802.1AD. It allow only doubled 0x8100 TPID. In simple port mode QinQ is enabled to preserve forwarding vlan tagged frames. Tag driver introduce most simple funcionality required for proper taging support. Reviewed-by: Linus Walleij <redacted> Signed-off-by: Pawel Dembicki <redacted> ---diff --git a/drivers/net/dsa/Kconfig b/drivers/net/dsa/Kconfig index 3ed5391bb18d..4cf0166fef7b 100644 --- a/drivers/net/dsa/Kconfig +++ b/drivers/net/dsa/Kconfig@@ -125,7 +125,7 @@ config NET_DSA_SMSC_LAN9303_MDIO config NET_DSA_VITESSE_VSC73XX tristate - select NET_DSA_TAG_NONE + select NET_DSA_TAG_VSC73XX
typo: "select NET_DSA_TAG_VSC73XX_8021Q". This does not do anything, and Kconfig still asks for a prompt for the config option that does exist.
select FIXED_PHY select VITESSE_PHY select GPIOLIB