Re: [PATCH net-next v2 1/7] net: dsa: vsc73xx: use read_poll_timeout instead delay loop
From: Andrew Lunn <andrew@lunn.ch>
Date: 2023-06-25 15:08:01
Also in:
lkml
From: Andrew Lunn <andrew@lunn.ch>
Date: 2023-06-25 15:08:01
Also in:
lkml
On Sun, Jun 25, 2023 at 01:53:36PM +0200, Pawel Dembicki wrote:
This commit switches delay loop to read_poll_timeout macro durring Arbiter empty check in adjust link function. As Russel King suggested: "This [change] avoids the issue that on the last iteration, the code reads the register, test it, find the condition that's being waiting for is false, _then_ waits and end up printing the error message - that last wait is rather useless, and as the arbiter state isn't checked after waiting, it could be that we had success during the last wait." It also remove one short msleep delay. Suggested-by: Russell King <linux@armlinux.org.uk> Signed-off-by: Pawel Dembicki <redacted>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew