On Wed, Jun 21, 2023 at 01:49:54PM +0300, Dan Carpenter wrote:

On Wed, Jun 21, 2023 at 12:47:30PM +0300, Dan Carpenter wrote:

quoted

The patchset doesn't include the actual interesting changes, just a
bunch of mechanical prep work.

I was wrong here, the patchset just hadn't all hit the mailing lists.

not even. It was that the patch got mangled by some error on my side.

I can't apply this patchset to anything.  I tried linux-next, net, and
net-next.  So it's hard to review.

All this applies cleanly to mcgrof's sysctl-next branch here
https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=sysctl-next

It looks like ensure_safe_net_sysctl() never got update to use
table_size...

Done. I realized this while checking out your other comments. thx.

You could easily write a static checker test to print a warning any time
that ->procname is checked for NULL.  I have attached a Smatch check.
You would need to added to check_list.h and recompile.

Awesome!!!, I had been doing this with coccinelle, I'll recompile with
smatch and see if I get extra hits. Thx!

net/sysctl_net.c:130 ensure_safe_net_sysctl() warn: checking ->procname 'ent->procname'

Done. Will be available in V2

regards,
dan carpenter

Best
-- 

Joel Granados