Thread (8 messages) 8 messages, 2 authors, 2023-06-23

Re: [PATCH 06/11] sysctl: Add size to register_net_sysctl function

From: Dan Carpenter <hidden>
Date: 2023-06-21 10:51:35
Also in: bridge, linux-hams, linux-rdma, linux-s390, linux-sctp, lkml, lvs-devel, mptcp, netfilter-devel

On Wed, Jun 21, 2023 at 12:47:30PM +0300, Dan Carpenter wrote:
The patchset doesn't include the actual interesting changes, just a
bunch of mechanical prep work.
I was wrong here, the patchset just hadn't all hit the mailing lists.
I can't apply this patchset to anything.  I tried linux-next, net, and
net-next.  So it's hard to review.

It looks like ensure_safe_net_sysctl() never got update to use
table_size...

You could easily write a static checker test to print a warning any time
that ->procname is checked for NULL.  I have attached a Smatch check.
You would need to added to check_list.h and recompile.

net/sysctl_net.c:130 ensure_safe_net_sysctl() warn: checking ->procname 'ent->procname'

regards,
dan carpenter

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help