On Sat, Jun 17, 2023 at 07:43:15AM +0100, David Howells wrote:

Simon Horman [off-list ref] wrote:

quoted

quoted

+	cache = get_cpu_ptr(&skb_splice_frag_cache);

...

quoted

quoted

+	put_cpu_ptr(skb_splice_frag_cache);

Hi David,

I don't think it makes any difference at run-time.
But to keep Sparse happy, perhaps this ought to be put_cpu_var()

Actually, the problem is a missing "&".  I think I should use put_cpu_ptr() to
match get_cpu_ptr().  It doesn't crash because the argument is ignored.

Thanks David, I agree that is a better idea.