Re: [PATCH net-next 01/17] net: Copy slab data for sendmsg(MSG_SPLICE_PAGES)

From
David Howells <dhowells@redhat.com>
Date
2023-06-17 06:44:35
Also in
linux-mm, lkml
Reply to
Simon Horman, 2023-06-16
Simon Horman [off-list ref] wrote:
quoted
+	cache = get_cpu_ptr(&skb_splice_frag_cache);
...
quoted
+	put_cpu_ptr(skb_splice_frag_cache);
Hi David,

I don't think it makes any difference at run-time.
But to keep Sparse happy, perhaps this ought to be put_cpu_var()
Actually, the problem is a missing "&".  I think I should use put_cpu_ptr() to
match get_cpu_ptr().  It doesn't crash because the argument is ignored.

David
Thread (21 messages) 21 messages, 2 authors, last reply 2023-06-17
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help