Thread (21 messages) 21 messages, 3 authors, 2024-01-10

Re: [PATCH net-next 08/30] net: dsa: mt7530: change p{5,6}_interface to p{5,6}_configured

From: Arınç ÜNAL <hidden>
Date: 2023-06-11 07:25:15
Also in: lkml

Possibly related (same subject, not in this thread)

On 10.06.2023 20:55, Vladimir Oltean wrote:
On Sat, Jun 10, 2023 at 01:57:27PM +0300, Arınç ÜNAL wrote:
quoted
I was able to confirm all user ports of the MT7531BE switch transmit/receive
traffic to/from the SGMII CPU port and computer fine after getting rid of
priv->info->cpu_port_config().

Tried all user ports being affine to the RGMII CPU port, that works too.

https://github.com/arinc9/linux/commit/4e79313a95d45950cab526456ef0030286ba4d4e
Did you do black-box testing after removing the code, or were you
also able to independently confirm that the configurations done by
cpu_port_config() were later overwritten? I'm trying to disambiguate
between "works by coincidence" and "works because the analysis was
correct".
I did my testing, merely to make sure we didn't miss anything as Russell 
already stated that the configuration from cpu_port_config() is later 
overwritten.

I could put some dev_info around to confirm the code path that 
overwrites the configuration.

Arınç
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help