Re: [PATCH net-next 08/30] net: dsa: mt7530: change p{5,6}_interface to p{5,6}_configured
From: Vladimir Oltean <olteanv@gmail.com>
Date: 2023-06-04 12:55:28
Also in:
linux-arm-kernel, linux-mediatek, lkml
Possibly related (same subject, not in this thread)
- 2024-01-11 · Re: [PATCH net-next 08/30] net: dsa: mt7530: change p{5,6}_interface to p{5,6}_configured · Vladimir Oltean <olteanv@gmail.com>
- 2024-01-10 · Re: [PATCH net-next 08/30] net: dsa: mt7530: change p{5,6}_interface to p{5,6}_configured · "Russell King (Oracle)" <linux@armlinux.org.uk>
- 2024-01-10 · Re: [PATCH net-next 08/30] net: dsa: mt7530: change p{5,6}_interface to p{5,6}_configured · Vladimir Oltean <olteanv@gmail.com>
- 2024-01-10 · Re: [PATCH net-next 08/30] net: dsa: mt7530: change p{5,6}_interface to p{5,6}_configured · Arınç ÜNAL <hidden>
- 2024-01-10 · Re: [PATCH net-next 08/30] net: dsa: mt7530: change p{5,6}_interface to p{5,6}_configured · Vladimir Oltean <olteanv@gmail.com>
On Sun, Jun 04, 2023 at 01:18:04PM +0100, Russell King (Oracle) wrote:
I don't remember whether Vladimir's firmware validator will fail for mt753x if CPU ports are not fully described, but that would be well worth checking. If it does, then we can be confident that phylink will always be used, and those bypassing calls should not be necessary.
It does, I've just retested this: [ 8.469152] mscc_felix 0000:00:00.5: OF node /soc/pcie@1f0000000/ethernet-switch@0,5/ports/port@4 of CPU port 4 lacks the required "phy-handle", "fixed-link" or "managed" properties [ 8.494571] mscc_felix 0000:00:00.5: error -EINVAL: Failed to register DSA switch [ 8.502151] mscc_felix: probe of 0000:00:00.5 failed with error -22