Re: [PATCH net-next 1/4] netlink: truncate overlength attribute list in nla_nest_end()

On Wed, 7 Jun 2023 16:31:48 +0300 Gal Pressman wrote:

On 06/06/2023 19:17, Jakub Kicinski wrote:

quoted

On Tue, 6 Jun 2023 11:01:14 +0300 Gal Pressman wrote:  

quoted

Jakub, sorry if this has been discussed already in the past, but can you
please clarify what is an accepted (or more importantly, not accepted)
solution for this issue? I'm not familiar with the history and don't
want to repeat previous mistakes.  

The problem is basically that attributes can only be 64kB and 
the legacy SR-IOV API wraps all the link info in an attribute.  

Isn't that a second order issue? The skb itself is limited to 32kB AFAICT.

Hm, you're right. But allocation larger than 32kB are costly.
We can't make every link dump allocate 64kB, it will cause
regressions on systems under memory pressure (== real world).

You'd need to come up with some careful scheme of using larger
buffers.

quoted

quoted

So far I've seen discussions about increasing the recv buffer size, and
this patchset which changes the GETLINK ABI, both of which were nacked.  

Filtering out some of the info, like the stats, is okay, but that just
increases the limit. A limit still exists.  

Any objections to at least take the second patch here?
It doesn't introduce any ABI changes, but will allow 'ip link show' to
work properly (although 'ip -s link show' will remain broken).

Yup, retest / repost?

quoted

quoted

Having 'ip link show' broken is very unfortunate :\, how should one
approach this issue in 2023?  

Sure is, which is why we should be moving away from the legacy SR-IOV
APIs.  

Agreed!
I do not suggest to extend/improve this API, just make sure it's not broken.