Thread (25 messages) flat view 25 messages, 6 authors, 2023-06-07

Re: [PATCH net-next 1/4] netlink: truncate overlength attribute list in nla_nest_end()

From: Gal Pressman <hidden>
Date: 2023-06-05 07:28:16

On 26/01/2021 19:51, Edwin Peer wrote:
On Mon, Jan 25, 2021 at 8:56 PM David Ahern [off-list ref] wrote:
quoted
I'm not a fan of the skb trim idea. I think it would be better to figure
out how to stop adding to the skb when an attr length is going to exceed
64kB. Not failing hard with an error (ip link sh needs to succeed), but
truncating the specific attribute of a message with a flag so userspace
knows it is short.
Absent the ability to do something useful in terms of actually
avoiding the overflow [1], I'm abandoning this approach entirely. I
have a different idea that I will propose in due course.

[1] https://marc.info/?l=linux-netdev&m=161163943811663

Regards,
Edwin Peer
Hello Edwin,

I'm also interested in getting this issue resolved, have you had any
progress since this series? Are you still working on it?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help