Re: [PATCH net-next v2 1/8] net: dpaa: Improve error reporting

On Wed, Jun 07, 2023 at 08:42:35AM +0200, Uwe Kleine-König wrote:

On Tue, Jun 06, 2023 at 07:03:31PM +0200, Maciej Fijalkowski wrote:

quoted

On Tue, Jun 06, 2023 at 06:28:22PM +0200, Uwe Kleine-König wrote:

quoted

Instead of the generic error message emitted by the driver core when a
remove callback returns an error code ("remove callback returned a
non-zero value. This will be ignored."), emit a message describing the
actual problem and return zero to suppress the generic message.

Note that apart from suppressing the generic error message there are no
side effects by changing the return value to zero. This prepares
changing the remove callback to return void.

Acked-by: Madalin Bucur <redacted>
Reviewed-by: Michal Kubiak <redacted>
Signed-off-by: Uwe Kleine-König <redacted>
---
 drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
index 431f8917dc39..6226c03cfca0 100644
--- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
+++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c

@@ -3516,6 +3516,8 @@ static int dpaa_remove(struct platform_device *pdev)
 	phylink_destroy(priv->mac_dev->phylink);
 
 	err = dpaa_fq_free(dev, &priv->dpaa_fq_list);
+	if (err)
+		dev_err(dev, "Failed to free FQs on remove\n");

so 'err' is now redundant - if you don't have any value in printing this
out then you could remove this variable altogether.

Good hint, err can have different values here (at least -EINVAL and
-EBUSY), so printing it has some values. I'll wait a bit for more
feedback to this series and then prepare a v3 with

	dev_err(dev, "Failed to free FQs on remove (%pE)\n", err);

							     ERR_PTR(err)

%p formats always take a pointer.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!