RE: [PATCH net-next v2 3/8] net: fec: Convert to platform remove callback returning void

-----Original Message-----
From: Uwe Kleine-König <redacted>
Sent: 2023年6月7日 0:28
To: Wei Fang <wei.fang@nxp.com>; David S. Miller <davem@davemloft.net>;
Eric Dumazet [off-list ref]; Jakub Kicinski [off-list ref];
Paolo Abeni [off-list ref]; Marc Kleine-Budde
[off-list ref]; Damien Le Moal
[off-list ref]; Michael Ellerman
[off-list ref]; Andy Shevchenko
[off-list ref]; Rob Herring [off-list ref]
Cc: Shenwei Wang <shenwei.wang@nxp.com>; Clark Wang
[off-list ref]; dl-linux-imx [off-list ref];
netdev@vger.kernel.org; kernel@pengutronix.de; Michal Kubiak
[off-list ref]
Subject: [PATCH net-next v2 3/8] net: fec: Convert to platform remove callback
returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Reviewed-by: Michal Kubiak <redacted>
Signed-off-by: Uwe Kleine-König <redacted>
---
 drivers/net/ethernet/freescale/fec_main.c        | 5 ++---
 drivers/net/ethernet/freescale/fec_mpc52xx.c     | 6 ++----
 drivers/net/ethernet/freescale/fec_mpc52xx_phy.c | 6 ++----
 3 files changed, 6 insertions(+), 11 deletions(-)

diff --git a/drivers/net/ethernet/freescale/fec_main.c

b/drivers/net/ethernet/freescale/fec_main.c
index 632bb4d589d7..f2b333b3f8c5 100644

--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c

@@ -4458,7 +4458,7 @@ fec_probe(struct platform_device *pdev)
 	return ret;
 }

-static int
+static void
 fec_drv_remove(struct platform_device *pdev)
 {
 	struct net_device *ndev = platform_get_drvdata(pdev);

@@ -4494,7 +4494,6 @@ fec_drv_remove(struct platform_device *pdev)
 	pm_runtime_disable(&pdev->dev);

 	free_netdev(ndev);
-	return 0;
 }

 static int __maybe_unused fec_suspend(struct device *dev)

@@ -4650,7 +4649,7 @@ static struct platform_driver fec_driver = {
 	},
 	.id_table = fec_devtype,
 	.probe	= fec_probe,
-	.remove	= fec_drv_remove,
+	.remove_new = fec_drv_remove,
 };

 module_platform_driver(fec_driver);