Re: [PATCH net-next v3 2/4] net: ethernet: altera-tse: Convert to mdio-regmap and use PCS Lynx
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
Date: 2023-05-26 10:43:03
Also in:
linux-arm-kernel, lkml
On Fri, May 26, 2023 at 10:05:17AM +0100, Russell King (Oracle) wrote:
On Fri, May 26, 2023 at 10:39:08AM +0200, Simon Horman wrote:quoted
On Fri, May 26, 2023 at 09:42:50AM +0200, Maxime Chevallier wrote:quoted
The newly introduced regmap-based MDIO driver allows for an easy mapping of an mdiodevice onto the memory-mapped TSE PCS, which is actually a Lynx PCS. Convert Altera TSE to use this PCS instead of the pcs-altera-tse, which is nothing more than a memory-mapped Lynx PCS. Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>Hi Maxime, I have some concerns about the error paths in this patch.We've had similar problems with mdio_device_create() vs the XPCS driver. I think it's time that we made this easier for users.
Patch series here: https://lore.kernel.org/all/ZHCGZ8IgAAwr8bla@shell.armlinux.org.uk/ (local) -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!