Re: [PATCH v4 0/7] fix fwnode_irq_get[_byname()] returnvalue

On 5/17/23 15:43, Linus Walleij wrote:

On Tue, May 16, 2023 at 9:12 AM Matti Vaittinen
[off-list ref] wrote:

quoted

The fwnode_irq_get() and the fwnode_irq_get_byname() may have returned
zero if mapping the IRQ fails. This contradicts the
fwnode_irq_get_byname() documentation. Furthermore, returning zero or
errno on error is unepected and can easily lead to problems
like:

Also, zero is not really a valid IRQ, it means NO_IRQ:
https://lwn.net/Articles/470820/

I'll apply the pinctrl patches.

Thanks Linus. I guess you noticed but please wait until the patch 1/7 
gets in as the pinctrl patches won't do "the right thing" without it. 
(Just ensuring we are on a same page ;) )

Yours,
	-- Matti

-- 
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~