Thread (17 messages) 17 messages, 6 authors, 2023-05-19

Re: [PATCH v4 5/7] pinctrl: ingenic: relax return value check for IRQ get

From: Paul Cercueil <paul@crapouillou.net>
Date: 2023-05-16 07:50:14
Also in: linux-acpi, linux-gpio, linux-iio, linux-mips, lkml, openbmc

Hi Matti,

Le mardi 16 mai 2023 à 10:13 +0300, Matti Vaittinen a écrit :
fwnode_irq_get[_byname]() were changed to not return 0 anymore.

Drop check for return value 0.

Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
Reviewed-by: Paul Cercueil <paul@crapouillou.net>

Cheers,
-Paul
quoted hunk ↗ jump to hunk
---

The first patch of the series changes the fwnode_irq_get() so this
depends
on the first patch of the series and should not be applied alone.
---
 drivers/pinctrl/pinctrl-ingenic.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-ingenic.c
b/drivers/pinctrl/pinctrl-ingenic.c
index 2f220a47b749..86e71ad703a5 100644
--- a/drivers/pinctrl/pinctrl-ingenic.c
+++ b/drivers/pinctrl/pinctrl-ingenic.c
@@ -4201,8 +4201,6 @@ static int __init ingenic_gpio_probe(struct
ingenic_pinctrl *jzpc,
        err = fwnode_irq_get(fwnode, 0);
        if (err < 0)
                return err;
-       if (!err)
-               return -EINVAL;
        jzgc->irq = err;
 
        girq = &jzgc->gc.irq;
-- 
2.40.1
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help