Re: [PATCH net 6/6] net/sched: qdisc_destroy() old ingress and clsact Qdiscs before grafting

On Thu, May 11, 2023 at 04:46:33PM -0700, Peilin Ye wrote:

On Thu, May 11, 2023 at 04:20:23PM -0700, Jakub Kicinski wrote:

quoted

quoted

But I see your point, thanks for the suggestion!  I'll try ->init() and
create v2.

->init() may be too early, aren't there any error points which could
prevent the Qdisc from binding after ->init() was called?

You're right, it's in qdisc_create(), argh...

->destroy() is called for all error points between ->init() and
dev_graft_qdisc().  I'll try handling it in ->destroy().

Thanks,
Peilin Ye