Re: [PATCH net 1/6] net/sched: sch_ingress: Only create under TC_H_INGRESS
From: Jamal Hadi Salim <jhs@mojatatu.com>
Date: 2023-05-08 11:23:21
Also in:
lkml
On Fri, May 5, 2023 at 8:12 PM Peilin Ye [off-list ref] wrote:
ingress Qdiscs are only supposed to be created under TC_H_INGRESS.
Similar to mq_init(), return -EOPNOTSUPP if 'parent' is not
TC_H_INGRESS.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Reported-by: syzbot+b53a9c0d1ea4ad62da8b@syzkaller.appspotmail.com
Link: https://lore.kernel.org/netdev/0000000000006cf87705f79acf1a@google.com (local)
Signed-off-by: Peilin Ye <redacted>Reviewed-by: Jamal Hadi Salim <jhs@mojatatu.com> Acked-by: Jamal Hadi Salim <jhs@mojatatu.com> cheers, jamal
quoted hunk ↗ jump to hunk
--- net/sched/sch_ingress.c | 3 +++ 1 file changed, 3 insertions(+)diff --git a/net/sched/sch_ingress.c b/net/sched/sch_ingress.c index 84838128b9c5..3d71f7a3b4ad 100644 --- a/net/sched/sch_ingress.c +++ b/net/sched/sch_ingress.c@@ -80,6 +80,9 @@ static int ingress_init(struct Qdisc *sch, struct nlattr *opt, struct net_device *dev = qdisc_dev(sch); int err; + if (sch->parent != TC_H_INGRESS) + return -EOPNOTSUPP; + net_inc_ingress_queue(); mini_qdisc_pair_init(&q->miniqp, sch, &dev->miniq_ingress); --2.20.1