Re: [PATCH v2 5/5] dt-bindings: net: ftgmac100: convert to yaml version from txt

From
Krzysztof Kozlowski <hidden>
Date
2023-05-10 14:51:09
Also in
linux-devicetree, lkml
Reply to
Ivan Mikhaylov, 2023-05-09
On 09/05/2023 16:35, Ivan Mikhaylov wrote:
Signed-off-by: Ivan Mikhaylov <redacted>
Need some commit msg.

---
 .../bindings/net/faraday,ftgmac100.yaml       | 110 ++++++++++++++++++
Missing actual conversion (removal).
quoted hunk ↗ jump to hunk
 1 file changed, 110 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
diff --git a/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml b/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
new file mode 100644
index 000000000000..98cd142f74bb
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
@@ -0,0 +1,110 @@
+# SPDX-License-Identifier: GPL-2.0
Dual-license, unless you copied some chunks of old binding... but was
there old binding?
quoted hunk ↗ jump to hunk
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/faraday,ftgmac100.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Faraday Technology FTGMAC100 gigabit ethernet controller
+
+allOf:
+  - $ref: "ethernet-controller.yaml#"
Drop quotes.

quoted hunk ↗ jump to hunk
+
+maintainers:
+  - Po-Yu Chuang <ratbert@faraday-tech.com>
+
+properties:
+  compatible:
+    oneOf:
+      - const: faraday,ftgmac100
+      - items:
+          - enum:
+              - aspeed,ast2400-mac
+              - aspeed,ast2500-mac
+              - aspeed,ast2600-mac
+          - const: faraday,ftgmac100
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    description: |
+      In accordance with the generic clock bindings.
Drop this part. Obvious.
quoted hunk ↗ jump to hunk
 Must describe the MAC
+      IP clock, and optionally an RMII RCLK gate for the AST2500/AST2600. The
+      required MAC clock must be the first cell.
The cells depend on clock provider. Do you mean something else?
quoted hunk ↗ jump to hunk
+    minItems: 1
+    maxItems: 2
+
+  clock-names:
+    items:
+      - enum:
+          - MACCLK
+          - RCLK
This does not allow two clocks... List all the items and add minItems: 1.

quoted hunk ↗ jump to hunk
+
+  phy-mode:
+    enum:
+      - rgmii
+      - rmii
+
+  phy-handle: true
+
+  use-ncsi:
+    description: |
Do not need '|' unless you need to preserve formatting.

I will stop review, because it depends whether this is true conversion
or new binding.

Best regards,
Krzysztof
Thread (22 messages) 22 messages, 4 authors, last reply 2023-06-04
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help